-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove multiaddr
dependency from libp2p-identity
#3656
Conversation
This PR also upgrades to |
I'd like to release |
In out-of-band meeting with @mxinden, we decided to not do this because the release tag would get lost in our Git history due to our squash-merge strategy. |
This comment was marked as resolved.
This comment was marked as resolved.
…-libp2p into libp2p-identity-no-multiaddr
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏 |
Please ping me once this is ready for a review. |
Will do! The order of things for this to happen is documented here: multiformats/rust-multiaddr#83 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case my latest comment is correct and rust-multihash
is released, feel free to merge here and release libp2p-identity
v0.2.0
.
Merging here based on @mxinden's review above. Worst case, the function can be added again in a patch-release. |
This updates `multiaddr` to version `0.19`. Depends-On: #3656. Depends-On: multiformats/rust-multiaddr#83. Resolves: #4039. Pull-Request: #4037.
This updates `multiaddr` to version `0.19`. Depends-On: libp2p#3656. Depends-On: multiformats/rust-multiaddr#83. Resolves: libp2p#4039. Pull-Request: libp2p#4037.
Description
Related: multiformats/rust-multiaddr#73.
Depends-On: #3514.
Notes & open questions
Depends on a new release ofmultihash
.Change checklist